Skip to content

Add support for ticklabelposition "inside"/"outside" for category axes with tickson set to "boundaries" #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for ticklabelposition "inside"/"outside" for category axes with tickson set to "boundaries" #7420

wants to merge 5 commits into from

Conversation

my-tien
Copy link
Contributor

@my-tien my-tien commented May 7, 2025

"top", "bottom", "left", "right" are still ignored if tickson is set to "boundaries".

Disclaimer I am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

my-tien added 2 commits May 7, 2025 13:49
@my-tien
Add support for ticklabelposition "inside"/"outside" for category a…
66328b4 
…xes with `tickson` set to "boundaries".

"top", "bottom", "left", "right" are ignored if `tickson` is set to "boundaries".
@my-tien
Add draftlog for 7420
c84ae91
@gvwilson gvwilson added feature something new community community contribution P1 needed for current cycle labels May 8, 2025
@my-tien
Copy link
Contributor Author

my-tien commented May 19, 2025

@emilykl @gvwilson In my other PR the baseline tests seem to be working again, maybe we can trigger this one's action as well to see if it works?

@emilykl
Copy link
Contributor

emilykl commented May 20, 2025

@my-tien I did re-trigger the tests and it's still failing -- I think it will need my PR #7418 to be merged but I'm just working through some final issues with that one, hopefully will be resolved by end of day.

@emilykl
Copy link
Contributor

emilykl commented May 21, 2025 •
edited
Loading

@my-tien I just merged #7418 which fixes the ModuleNotFoundError: No module named 'plotly' error in the make-baselines CI step.

You should merge main master into this branch, it will resolve some of the CI issues.

@emilykl
Copy link
Contributor

emilykl commented May 22, 2025 •
edited
Loading

@my-tien Just making sure I understand the effect of this change — can you confirm whether the below is correct?

Previously, if you set tickson='boundaries' and (ticklabelposition='inside' or ticklabelposition='outside'), ticklabelposition had no effect. This PR makes it so tickson='boundaries' and (ticklabelposition='inside' or ticklabelposition='outside') are both respected. Effectively this only makes a difference when ticklabelposition='inside', since 'outside' is the default anyway.

@my-tien
Copy link
Contributor Author

my-tien commented May 22, 2025 •
edited
Loading

@my-tien Just making sure I understand the effect of this change — can you confirm whether the below is correct?

Previously, if you set tickson='boundaries' and (ticklabelposition='inside' or ticklabelposition='outside'), ticklabelposition had no effect. This PR makes it so tickson='boundaries' and (ticklabelposition='inside' or ticklabelposition='outside') are both respected. Effectively this only makes a difference when ticklabelposition='inside', since 'outside' is the default anyway.

Yes, exactly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvwilson gvwilson gvwilson approved these changes

Assignees

@emilykl emilykl

@marthacryan marthacryan

Labels
community community contribution feature something new P1 needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@my-tien @emilykl @gvwilson @marthacryan